yuriy/video-uploader
1
0
Fork 0
Code Issues 9 Pull Requests Packages Projects Releases 24 Wiki Activity

WIP: #12, maybe also #13: change VideoTags parsing a bit to fix some minor issues with Brighteon #14

Closed
jamesapyrich wants to merge 1 commits from videotags-updates into main
pull from: videotags-updates
merge into: yuriy:main
Conversation 0 Commits 1 Files Changed 1 +20 -6
jamesapyrich commented 2024-01-02 20:07:15 +00:00
Collaborator
Copy Link

So! Not sure if this is ready to be merged, and I've not tested it... the issues I'm trying to address is that we shouldn't be splitting tags up by words for videos.

Brighteon in particular has problems with this, as it complains about more than 25 tags, and sometimes splitting tags like this results in duplicate tags, which it also doesn't like.

Some sites also complain about non-Latin chars in the tags, which this change does not address... also, haven't spent any time figuring out if the function defined on lines 1160-1164 should be organized in another file, perhaps an internal libraries/functions file, or what!

Anyway, this hopefully gets us closer to resolving some of the issues I opened around tags.

So! Not sure if this is ready to be merged, and I've not tested it... the issues I'm trying to address is that we shouldn't be splitting tags up by words for videos. Brighteon in particular has problems with this, as it complains about more than 25 tags, and sometimes splitting tags like this results in duplicate tags, which it also doesn't like. Some sites also complain about non-Latin chars in the tags, which this change does not address... also, haven't spent any time figuring out if the function defined on lines 1160-1164 should be organized in another file, perhaps an internal libraries/functions file, or what! Anyway, this hopefully gets us closer to resolving some of the issues I opened around tags.
jamesapyrich added 1 commit 2024-01-02 20:07:18 +00:00
#12, maybe also #13: change VideoTags parsing a bit to fix some minor issues with Brighteon 6b9038b15a
yuriy closed this pull request 2024-01-16 10:49:06 +00:00

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Priority-A
Priority-B
Priority-C
Priority-D
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
jamesapyrich yuriy
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: yuriy/video-uploader#14
No description provided.
Delete Branch "videotags-updates"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?