WIP: #12, maybe also #13: change VideoTags parsing a bit to fix some minor issues with Brighteon #14

Closed
jamesapyrich wants to merge 1 commits from videotags-updates into main
Collaborator

So! Not sure if this is ready to be merged, and I've not tested it... the issues I'm trying to address is that we shouldn't be splitting tags up by words for videos.

Brighteon in particular has problems with this, as it complains about more than 25 tags, and sometimes splitting tags like this results in duplicate tags, which it also doesn't like.

Some sites also complain about non-Latin chars in the tags, which this change does not address... also, haven't spent any time figuring out if the function defined on lines 1160-1164 should be organized in another file, perhaps an internal libraries/functions file, or what!

Anyway, this hopefully gets us closer to resolving some of the issues I opened around tags.

So! Not sure if this is ready to be merged, and I've not tested it... the issues I'm trying to address is that we shouldn't be splitting tags up by words for videos. Brighteon in particular has problems with this, as it complains about more than 25 tags, and sometimes splitting tags like this results in duplicate tags, which it also doesn't like. Some sites also complain about non-Latin chars in the tags, which this change does not address... also, haven't spent any time figuring out if the function defined on lines 1160-1164 should be organized in another file, perhaps an internal libraries/functions file, or what! Anyway, this hopefully gets us closer to resolving some of the issues I opened around tags.
jamesapyrich added 1 commit 9 months ago
yuriy closed this pull request 8 months ago
Please reopen this pull request to perform a merge.
You can also view command line instructions.

Step 1:

From your project repository, check out a new branch and test the changes.
git checkout -b videotags-updates main
git pull origin videotags-updates

Step 2:

Merge the changes and update on Gitea.
git checkout main
git merge --no-ff videotags-updates
git push origin main
Sign in to join this conversation.
No reviewers
No Milestone
No project
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: yuriy/video-uploader#14
Loading…
There is no content yet.