Video tags should not be split into separate tags by spaces
#12
Closed
opened 11 months ago by jamesapyrich
·
9 comments
Loading…
Reference in New Issue
There is no content yet.
Delete Branch '%!s(<nil>)'
Deleting a branch is permanent. It CANNOT be undone. Continue?
Some tags are created with spaces. These are currently being split into separate tags, but this can sometimes create duplicate tags, and often creates too many tags. Instead, we should preserve spaces and transform the tags according to the individual site's need.
Are the tags always a comma seperated list then?
In your commit i see that you only chagned the parsing for the video tags.
b0290eef6e
Also, are the video tags and podcast tags still different from each other?
I don't think so, they both get sourced from a single
keywords.txt
file, and I've never made any efforts to make them separate. Was that one of the original requirements?And I only changed the parsing for the video tags because the podcast tags weren't being split by spaces
yep
I did want to go back to the podcast tags and unslugify them (don't convert spaces into dashes and such).
I did encounter some other sites that have issues with tags, such as if a tag has uppercase letters. I forget what site it was, I'll come back if it happens again.
In the code i have it read the keywords.txt file and pull that in as a variable for both videotags and podcast tags, THEN if a keywords_podcast.txt file exists, that gets pulled in for podcast tags. Stef used to have two different files, that's why there's two fields for the tags in the GUi.
Ah, well, I didn't know about that. I think that's probably a fine feature to keep in, I might start to leverage that. There are some common tags that make sense for videos that don't make as much sense for podcasts (e.g.
reason, evidence, philosophy
), and knowing I can put those in separately is actually good.Done:
0f679a0792