Video tags should not be split into separate tags by spaces #12

Closed
opened 9 months ago by jamesapyrich · 9 comments
Collaborator

Some tags are created with spaces. These are currently being split into separate tags, but this can sometimes create duplicate tags, and often creates too many tags. Instead, we should preserve spaces and transform the tags according to the individual site's need.

Some tags are created with spaces. These are currently being split into separate tags, but this can sometimes create duplicate tags, and often creates too many tags. Instead, we should preserve spaces and transform the tags according to the individual site's need.
yuriy commented 8 months ago
Owner

Some tags are created with spaces. These are currently being split into separate tags, but this can sometimes create duplicate tags, and often creates too many tags. Instead, we should preserve spaces and transform the tags according to the individual site's need.

Are the tags always a comma seperated list then?

> Some tags are created with spaces. These are currently being split into separate tags, but this can sometimes create duplicate tags, and often creates too many tags. Instead, we should preserve spaces and transform the tags according to the individual site's need. Are the tags always a comma seperated list then?
yuriy commented 8 months ago
Owner

In your commit i see that you only chagned the parsing for the video tags.
b0290eef6e

Also, are the video tags and podcast tags still different from each other?

In your commit i see that you only chagned the parsing for the video tags. https://freedomain.dev/yuriy/video-uploader/commit/b0290eef6e1b6f25e90f649ee30b7c9822e0961f Also, are the video tags and podcast tags still different from each other?
Poster
Collaborator

In your commit i see that you only chagned the parsing for the video tags.
b0290eef6e

Also, are the video tags and podcast tags still different from each other?

I don't think so, they both get sourced from a single keywords.txt file, and I've never made any efforts to make them separate. Was that one of the original requirements?

> > > In your commit i see that you only chagned the parsing for the video tags. > https://freedomain.dev/yuriy/video-uploader/commit/b0290eef6e1b6f25e90f649ee30b7c9822e0961f > > Also, are the video tags and podcast tags still different from each other? I don't think so, they both get sourced from a single `keywords.txt` file, and I've never made any efforts to make them separate. Was that one of the original requirements?
Poster
Collaborator

And I only changed the parsing for the video tags because the podcast tags weren't being split by spaces

And I only changed the parsing for the video tags because the podcast tags weren't being split by spaces
Poster
Collaborator

Some tags are created with spaces. These are currently being split into separate tags, but this can sometimes create duplicate tags, and often creates too many tags. Instead, we should preserve spaces and transform the tags according to the individual site's need.

Are the tags always a comma seperated list then?

yep

> > Some tags are created with spaces. These are currently being split into separate tags, but this can sometimes create duplicate tags, and often creates too many tags. Instead, we should preserve spaces and transform the tags according to the individual site's need. > > Are the tags always a comma seperated list then? yep
Poster
Collaborator

I did want to go back to the podcast tags and unslugify them (don't convert spaces into dashes and such).

I did encounter some other sites that have issues with tags, such as if a tag has uppercase letters. I forget what site it was, I'll come back if it happens again.

I did want to go back to the podcast tags and unslugify them (don't convert spaces into dashes and such). I did encounter some other sites that have issues with tags, such as if a tag has uppercase letters. I forget what site it was, I'll come back if it happens again.
yuriy commented 8 months ago
Owner

In your commit i see that you only chagned the parsing for the video tags.
b0290eef6e

Also, are the video tags and podcast tags still different from each other?

I don't think so, they both get sourced from a single keywords.txt file, and I've never made any efforts to make them separate. Was that one of the original requirements?

In the code i have it read the keywords.txt file and pull that in as a variable for both videotags and podcast tags, THEN if a keywords_podcast.txt file exists, that gets pulled in for podcast tags. Stef used to have two different files, that's why there's two fields for the tags in the GUi.

> > > > > > In your commit i see that you only chagned the parsing for the video tags. > > https://freedomain.dev/yuriy/video-uploader/commit/b0290eef6e1b6f25e90f649ee30b7c9822e0961f > > > > Also, are the video tags and podcast tags still different from each other? > > I don't think so, they both get sourced from a single `keywords.txt` file, and I've never made any efforts to make them separate. Was that one of the original requirements? In the code i have it read the keywords.txt file and pull that in as a variable for both videotags and podcast tags, THEN if a keywords_podcast.txt file exists, that gets pulled in for podcast tags. Stef used to have two different files, that's why there's two fields for the tags in the GUi.
Poster
Collaborator

Ah, well, I didn't know about that. I think that's probably a fine feature to keep in, I might start to leverage that. There are some common tags that make sense for videos that don't make as much sense for podcasts (e.g. reason, evidence, philosophy), and knowing I can put those in separately is actually good.

Ah, well, I didn't know about that. I think that's probably a fine feature to keep in, I might start to leverage that. There are some common tags that make sense for videos that don't make as much sense for podcasts (e.g. `reason, evidence, philosophy`), and knowing I can put those in separately is actually good.
yuriy commented 8 months ago
Owner

Done: 0f679a0792

Done: https://freedomain.dev/yuriy/video-uploader/commit/0f679a07920938f5e3904580a432ca4cafbb8d12
yuriy closed this issue 8 months ago
Sign in to join this conversation.
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: yuriy/video-uploader#12
Loading…
There is no content yet.