Video uploader is inconsistent if you change the image filename in the text box #15

Closed
opened 8 months ago by jamesapyrich · 3 comments
Collaborator

It appears that if I change the filename for the image in the text box manually (meaning, edit the filename directly), it will use this text for the video uploads, but it will use the originally discovered file for everything else (podcast upload, etc.).

I haven't tried clicking "Select" to re-select the file I want, but if I know I have both a png and a jpg and I want to use the jpg (because the png is over 2MB and Brighteon is unhappy with that), I really should be able to enter that new filename and have it persist for everything.

The workaround if you find yourself in this situation is to upload both assets to the CDN (because the podcast will get saved with png as well).

It appears that if I change the filename for the image in the text box manually (meaning, edit the filename directly), it will use this text for the video uploads, but it will use the originally discovered file for everything else (podcast upload, etc.). I haven't tried clicking "Select" to re-select the file I want, but if I know I have both a `png` and a `jpg` and I want to use the `jpg` (because the `png` is over 2MB and Brighteon is unhappy with that), I really should be able to enter that new filename and have it persist for everything. The workaround if you find yourself in this situation is to upload both assets to the CDN (because the podcast will get saved with `png` as well).
yuriy commented 8 months ago
Owner

When i first wrote the code Stef told me that 100% of the time that any jpg/png image that is in the project directory is the thumbnail, and there will always be just 1 image, so i never wrote any code to save any changes to that filepath between restarts of the script. What I think happened to you was you made the change, ran the upload, there was maybe a site that failed so you did a reload, and at this point the script looped through all the files in the directory and the first jpg/png file it landed it it selected as the thumbnail and then stopped the loop.

I will have the script save the filepath to the project setting .ini to fix this

When i first wrote the code Stef told me that 100% of the time that any jpg/png image that is in the project directory is the thumbnail, and there will always be just 1 image, so i never wrote any code to save any changes to that filepath between restarts of the script. What I think happened to you was you made the change, ran the upload, there was maybe a site that failed so you did a reload, and at this point the script looped through all the files in the directory and the first jpg/png file it landed it it selected as the thumbnail and then stopped the loop. I will have the script save the filepath to the project setting .ini to fix this
yuriy commented 8 months ago
Owner

Fixed: 1d926a91a7

Fixed: https://freedomain.dev/yuriy/video-uploader/commit/1d926a91a7acb0ace2ba7b7d699e3bf3f9ae00e7
yuriy closed this issue 8 months ago
Poster
Collaborator

Ah, well, see, that may have been true for Stef... it's not true for me, but then I didn't realize this was an expectation 😅

Ah, well, see, that may have been true for Stef... it's not true for me, but then I didn't realize this was an expectation 😅
Sign in to join this conversation.
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: yuriy/video-uploader#15
Loading…
There is no content yet.